4638 Improve URL formatting#695
Merged
Merged
Conversation
Contributor
Author
|
Note that there are a couple of places where we still use fmt to construct the URL. In these cases the URLs are static, or the only dynamic portion is inside the host (rather than the path), which the url package does not encode (and therefore we get no benefit from using the package to format these URLs). |
JonJagger
approved these changes
Mar 11, 2026
dangrondahl
added a commit
that referenced
this pull request
May 29, 2026
Four commands still built URLs with fmt.Sprintf("%s/api/v2/...",
global.Host, ...), producing double-slash URLs and 404s when --host
or KOSLI_HOST had a trailing slash. Switch to url.JoinPath with
url.Values for query params, matching the pattern adopted in #695.
Affected commands: list artifacts, list approvals, list snapshots,
diff snapshots.
3 tasks
dangrondahl
added a commit
that referenced
this pull request
May 29, 2026
* fix: use url.JoinPath for list/diff command URLs (#913) Four commands still built URLs with fmt.Sprintf("%s/api/v2/...", global.Host, ...), producing double-slash URLs and 404s when --host or KOSLI_HOST had a trailing slash. Switch to url.JoinPath with url.Values for query params, matching the pattern adopted in #695. Affected commands: list artifacts, list approvals, list snapshots, diff snapshots. * refactor: use strconv for query-param conversion Align list/diff URL construction with the codebase convention (logEnvironment.go, listTrails.go) by using strconv.Itoa / strconv.FormatBool instead of fmt.Sprintf for int/bool query parameters. Cosmetic; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the url package to format the URLS throughout the CLI code.